-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed "refactoring" is not compiling on Levante (in CPU). #615
Conversation
Please note that refactoring branch shall not be used anymore as the target of commits. See my email from 21.6.2024
Do you wish to merge these changes back, then they shall be merged into the main branch. In that case rebase to main please. |
Please, do not close @basava70's PRs, they might need to be merged into other branches, in that case we need to edit the PR and target another branch, but the PR should still be available so that we can discuss the merging. |
Is |
This I don't know. It might be production_DE, which I overzealously closed, sorry for that. I don't think it's refactoring, which was the misnamed general default branch before we made main. If it was refactoring, then it would now be main. |
DestinE is currently using the tag |
@basava70, what work is missing in this branch? |
Are we sure the latest main branch is not compiling on levante without these changes? |
Ok, the code in the main branch does pass the test and compiles on Levante without any changes. However, it compiles only using shell.gnu script and doesn't take shell.intel (or shell.nvhpc for gpu computation). To enable this, we need to add code in env.sh as given in this PR. |
Co-authored-by: Miguel <[email protected]>
refactoring is not compiling on Levante, either on shell.inter or shell.gnu.
blas not found error.
Fixed it by commenting export commands in env.sh.
Also added option to choose which compiler to use on Levante. It is set to shell.gnu. I copied Suvi's code to add compID regex to give arguments like " ./configure levante.intel ", " ./configure levante.gnu", " ./configure levante.nvhpc".