Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed "refactoring" is not compiling on Levante (in CPU). #615

Merged
merged 5 commits into from
Sep 24, 2024

Conversation

basava70
Copy link
Collaborator

refactoring is not compiling on Levante, either on shell.inter or shell.gnu.
blas not found error.
Fixed it by commenting export commands in env.sh.
Also added option to choose which compiler to use on Levante. It is set to shell.gnu. I copied Suvi's code to add compID regex to give arguments like " ./configure levante.intel ", " ./configure levante.gnu", " ./configure levante.nvhpc".

@JanStreffing
Copy link
Collaborator

JanStreffing commented Aug 15, 2024

Please note that refactoring branch shall not be used anymore as the target of commits. See my email from 21.6.2024

If you are not a FESOM model user, please ignore this email.

If you are, you might know, that the default FESOM2 master branch had been falling behind the refactoring branch with no merger of refactoring into master for about two years. Thus refactoring had become an unofficial de-facto default branch. Today we created an official new default branch: main. All Merge Requests with the base refactoring were rebased onto main. If you develop on the FESOM2 code, from here on out please branch off from and merge back into main. Thank you!

Do you wish to merge these changes back, then they shall be merged into the main branch. In that case rebase to main please.

@mandresm
Copy link
Collaborator

Please, do not close @basava70's PRs, they might need to be merged into other branches, in that case we need to edit the PR and target another branch, but the PR should still be available so that we can discuss the merging.

@mandresm
Copy link
Collaborator

Do you wish to merge these changes back, then they shall be merged into the main branch. In that case rebase to main please.

Is main used in DestinE? Because it's great that @basava70 changes make it to main but it's a requirement that they make it to the branch used in DestinE

@JanStreffing
Copy link
Collaborator

This I don't know. It might be production_DE, which I overzealously closed, sorry for that. I don't think it's refactoring, which was the misnamed general default branch before we made main. If it was refactoring, then it would now be main.

@sebastianbeyer
Copy link
Collaborator

DestinE is currently using the tag 2.5.0.6_de, but will be using 'regular' tags from main soon. So, if this is still required, please target main

@mandresm
Copy link
Collaborator

@basava70, what work is missing in this branch?

@JanStreffing JanStreffing changed the base branch from refactoring to main September 23, 2024 06:46
@JanStreffing
Copy link
Collaborator

Are we sure the latest main branch is not compiling on levante without these changes?

@basava70
Copy link
Collaborator Author

basava70 commented Sep 24, 2024

Ok, the code in the main branch does pass the test and compiles on Levante without any changes. However, it compiles only using shell.gnu script and doesn't take shell.intel (or shell.nvhpc for gpu computation). To enable this, we need to add code in env.sh as given in this PR.
PS. This code is provided by @suvarchal long back and I cannot find which commit that was, so I copied it by hand in this PR.

env.sh Outdated Show resolved Hide resolved
Co-authored-by: Miguel <[email protected]>
@JanStreffing JanStreffing added this to the FESOM 2.6 milestone Sep 24, 2024
@JanStreffing JanStreffing merged commit e900ff0 into main Sep 24, 2024
4 checks passed
@JanStreffing JanStreffing deleted the refactoring_blas_bug_fix branch September 24, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants